Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update allowed container tags #8056

Merged
merged 3 commits into from
Mar 9, 2017
Merged

update allowed container tags #8056

merged 3 commits into from
Mar 9, 2017

Conversation

steros
Copy link
Contributor

@steros steros commented Jan 5, 2017 •
edited by vrann
Loading

tag "nav" was missing in the xml schema file although it is allowed to use in container tags.
"aside" was missing at all.

steros added 2 commits January 5, 2017 16:29
@steros
add aside and missing nav element
aeae1c0 
add aside and nav html5 elements to the available tag types
@steros
add aside element
e46aaa1 
add html5 aside element to the allowed tags in containers
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 5, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@steros
Copy link
Contributor Author

steros commented Jan 6, 2017

Could someone lend me a hand here, this is my first ever pull request 😅
I have a failing test cause the text exception does not return the expected text as there is the new tag "aside" missing.
How can I append the changed test file to this pull request or do I have to close this one and open a new one?
I need change this file and append it to this pull:
https://github.com/magento/magento2/blob/1ade3b769a937f19682bbbe4e51b6c956147952f/dev/tests/integration/testsuite/Magento/Framework/View/LayoutTest.php

@antonkril
Copy link
Contributor

@steros take a look here: http://stackoverflow.com/questions/9790448/how-to-update-a-pull-request

@steros
Copy link
Contributor Author

steros commented Jan 7, 2017

Cool thanks, that was easier than I expected ☺️

@vrann vrann self-assigned this Mar 6, 2017
@vrann vrann added this to the March 2017 milestone Mar 6, 2017
@magento-team magento-team merged commit d7ad584 into magento:develop Mar 9, 2017
@vrann
Copy link
Contributor

vrann commented Mar 9, 2017

@steros PR was accepted, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonkril antonkril antonkril approved these changes

Assignees

@vrann vrann

Labels
None yet
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@steros @magento-cicd2 @antonkril @vrann @magento-team